bugfix (file-exists): Uncontrolled data used in path expression #79230
+13
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
ngadeg
approved these changes
May 15, 2025
ngadeg
approved these changes
May 15, 2025
ngadeg
approved these changes
May 15, 2025
ngadeg
approved these changes
May 15, 2025
ngadeg
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next.js/packages/next/src/lib/file-exists.ts
Line 22 in ae4c19c
fix the issue need to validate and sanitize the
fileNameparameter before using it in file system operations. The best approach is to ensure that thefileNameis resolved within a safe root directory and does not allow access to files outside this directory. This can be achieved by:fileNameusingpath.resolveto remove any..segments.sanitize-filenameto further restrict the file name to a safe format.The changes will be made in the
fileExistsfunction inpackages/next/src/lib/file-exists.ts. A newrootDirparameter will be introduced to specify the safe root directory, and thefileNamewill be validated against this directory.