Skip to content

Docs IA 2.0: Review fetching page and move examples #79200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: canary
Choose a base branch
from
Open

Docs IA 2.0: Review fetching page and move examples #79200

wants to merge 18 commits into from

Conversation

delbaoliveira
Copy link
Contributor

@delbaoliveira delbaoliveira commented May 14, 2025 •
edited
Loading

Part of: https://linear.app/vercel/issue/DOC-4639/ia-20-migrate-bya-pages
No redirects needed yet as the page hasn't been deleted.

@ijjk ijjk added created-by: Next.js DevEx team PRs by the DX team. Documentation Related to Next.js' official documentation. labels May 14, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 14, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 926037d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2025 •
edited
Loading

All broken links are now fixed, thank you!

@delbaoliveira delbaoliveira changed the title Docs IA 2.0: Delete Fetching and Caching page Docs IA 2.0: Review fetching page and move content May 15, 2025
@delbaoliveira delbaoliveira changed the title Docs IA 2.0: Review fetching page and move content Docs IA 2.0: Review fetching page and move examples May 15, 2025
@delbaoliveira delbaoliveira marked this pull request as ready for review May 15, 2025 17:06
leerob
leerob reviewed May 15, 2025
View reviewed changes
docs/01-app/01-getting-started/09-fetching-data.mdx
'Do not pass the whole user object to the client',
data
)
experimental_taintUniqueValue(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably more for a deep dive than getting started. Thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does feel like non-essential knowledge. Maybe something for the experimental.taint API reference?
https://linear.app/vercel/issue/DOC-4668/document-the-experimentaltaint-option-in-nextconfigts

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The experimenta.taint API is almost ready, so we can probably reduce the amount of info on this section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leerob leerob leerob left review comments

@icyJoseph icyJoseph icyJoseph left review comments

@Hardanish-Singh Hardanish-Singh Hardanish-Singh approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
created-by: Next.js DevEx team PRs by the DX team. Documentation Related to Next.js' official documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@delbaoliveira @leerob @icyJoseph @Hardanish-Singh @ijjk