Skip to content

chore(turbopack): Add a span for sourcemap generation #79170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2025
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented May 13, 2025

What?

Add a tracing span for generate_js_source_map.

Why?

I need to distinguish the CPU usage and memory usage between the source map and the real minifier.

@kdy1 kdy1 requested a review from a team May 13, 2025 18:16
@kdy1 kdy1 self-assigned this May 13, 2025
@kdy1 kdy1 enabled auto-merge (squash) May 13, 2025 18:22
@ijjk
Copy link
Member

ijjk commented May 13, 2025

Failing test suites

Commit: c13bf8d

pnpm test-dev test/e2e/app-dir/app-basepath/index.test.ts

  • app dir - basepath > should successfully hard navigate from pages -> app
Expand output

● app dir - basepath › should successfully hard navigate from pages -> app

page.waitForSelector: Timeout 10000ms exceeded.
Call log:
  - waiting for locator('#page-2')

  454 |   waitForElementByCss(selector: string, timeout = 10_000) {
  455 |     return this.startChain(async () => {
> 456 |       const el = await page.waitForSelector(selector, {
      |                             ^
  457 |         timeout,
  458 |         state: 'attached',
  459 |       })

  at waitForSelector (lib/browsers/playwright.ts:456:29)
  at Playwright._chain (lib/browsers/playwright.ts:568:23)
  at Playwright._chain [as startChain] (lib/browsers/playwright.ts:549:17)
  at Playwright.startChain [as waitForElementByCss] (lib/browsers/playwright.ts:455:17)
  at Object.waitForElementByCss (e2e/app-dir/app-basepath/index.test.ts:16:19)

Read more about building and testing Next.js in contributing.md.

__NEXT_EXPERIMENTAL_PPR=true pnpm test-dev test/e2e/persistent-caching/persistent-caching.test.ts (PPR)

  • persistent-caching > should persistent cache loaders
Expand output

● persistent-caching › should persistent cache loaders

expect(received).toBe(expected) // Object.is equality

Expected: "Timestamp = 1747163842704"
Received: "Timestamp = 1747163865031"

  66 |     {
  67 |       const browser = await next.browser('/pages')
> 68 |       expect(await browser.elementByCss('main').text()).toBe(pagesTimestamp)
     |                                                         ^
  69 |       await browser.close()
  70 |     }
  71 |   })

  at Object.toBe (e2e/persistent-caching/persistent-caching.test.ts:68:57)

Read more about building and testing Next.js in contributing.md.

@kdy1 kdy1 merged commit bcd799f into canary May 13, 2025
254 of 257 checks passed
@kdy1 kdy1 deleted the kdy1/minify-span branch May 13, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants