Skip to content

Docs: Change mjs codeblocks to js #79163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Conversation

icyJoseph
Copy link
Contributor

Closes: https://linear.app/vercel/issue/DOC-4450/missing-syntax-highlighting-on-mjs-codeblocks

It looks like shiki doesn't really support mjs code blocks. For now, we keep the filename with .mjs extension, but change to js code block type.

@icyJoseph icyJoseph requested a review from delbaoliveira May 13, 2025 17:09
@icyJoseph icyJoseph self-assigned this May 13, 2025
@icyJoseph icyJoseph added the Documentation Related to Next.js' official documentation. label May 13, 2025
@ijjk
Copy link
Member

ijjk commented May 13, 2025

Allow CI Workflow Run

  • approve CI run for commit: 08dd3e6

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@icyJoseph icyJoseph added the created-by: Next.js DevEx team PRs by the DX team. label May 13, 2025
@icyJoseph icyJoseph requested a review from a team May 13, 2025 19:10
Copy link

changeset-bot bot commented May 14, 2025

⚠️ No Changeset found

Latest commit: 52caefa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@delbaoliveira delbaoliveira merged commit e366726 into canary May 14, 2025
69 checks passed
@delbaoliveira delbaoliveira deleted the docs/mjs-syntax-highlighting branch May 14, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
created-by: Next.js DevEx team PRs by the DX team. Documentation Related to Next.js' official documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants