Turbopack: remove dead code (#79280)

mischnic · web-flow · commit 13af7b57f641 · 2025-05-16T14:58:29.000+02:00
- `IncludeIdentModule` is unused (and incompatible with the ModuleGraph anyway)
- Cleanup some `todo!()`s
diff --git a/turbopack/crates/turbopack-dev-server/src/source/static_assets.rs b/turbopack/crates/turbopack-dev-server/src/source/static_assets.rs
@@ -140,8 +140,9 @@ impl Introspectable for StaticAssetsContentSource {
                             .to_resolved()
                             .await?,
                         ),
-                        DirectoryEntry::Other(_) => todo!("what's DirectoryContent::Other?"),
-                        DirectoryEntry::Error => todo!(),
+                        DirectoryEntry::Other(_) | DirectoryEntry::Error => {
+                            todo!("unsupported DirectoryContent variant: {entry:?}")
+                        }
                     };
                     Ok((ResolvedVc::cell(name.clone()), child))
                 }
diff --git a/turbopack/crates/turbopack-ecmascript/src/async_chunk/module.rs b/turbopack/crates/turbopack-ecmascript/src/async_chunk/module.rs
@@ -76,7 +76,7 @@ impl Module for AsyncLoaderModule {
 impl Asset for AsyncLoaderModule {
     #[turbo_tasks::function]
     fn content(&self) -> Vc<AssetContent> {
-        todo!()
+        panic!("content() should not be called");
     }
 }
 
diff --git a/turbopack/crates/turbopack-ecmascript/src/manifest/chunk_asset.rs b/turbopack/crates/turbopack-ecmascript/src/manifest/chunk_asset.rs
@@ -152,7 +152,7 @@ impl Module for ManifestAsyncModule {
 impl Asset for ManifestAsyncModule {
     #[turbo_tasks::function]
     fn content(&self) -> Vc<AssetContent> {
-        todo!()
+        panic!("content() should not be called");
     }
 }
 
diff --git a/turbopack/crates/turbopack-ecmascript/src/references/external_module.rs b/turbopack/crates/turbopack-ecmascript/src/references/external_module.rs
@@ -268,35 +268,3 @@ impl EcmascriptChunkItem for CachedExternalModuleChunkItem {
         )
     }
 }
-
-/// A module that only has an ident and no content nor references.
-///
-/// It is used to include a module's ident in the module graph before the module
-/// itself is resolved, as is the case with NextServerComponentModule's
-/// "client modules" and "ssr modules".
-#[turbo_tasks::value]
-pub struct IncludeIdentModule {
-    ident: ResolvedVc<AssetIdent>,
-}
-
-#[turbo_tasks::value_impl]
-impl IncludeIdentModule {
-    #[turbo_tasks::function]
-    pub fn new(ident: ResolvedVc<AssetIdent>) -> Vc<Self> {
-        Self { ident }.cell()
-    }
-}
-
-impl Asset for IncludeIdentModule {
-    fn content(self: Vc<Self>) -> Vc<AssetContent> {
-        todo!("IncludeIdentModule doesn't implement content()")
-    }
-}
-
-#[turbo_tasks::value_impl]
-impl Module for IncludeIdentModule {
-    #[turbo_tasks::function]
-    fn ident(&self) -> Vc<AssetIdent> {
-        *self.ident
-    }
-}
diff --git a/turbopack/crates/turbopack-ecmascript/src/worker_chunk/module.rs b/turbopack/crates/turbopack-ecmascript/src/worker_chunk/module.rs
@@ -62,7 +62,7 @@ impl Module for WorkerLoaderModule {
 impl Asset for WorkerLoaderModule {
     #[turbo_tasks::function]
     fn content(&self) -> Vc<AssetContent> {
-        todo!()
+        panic!("content() should not be called");
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ impl Module for AsyncLoaderModule {`
`76`	`76`	`impl Asset for AsyncLoaderModule {`
`77`	`77`	`#[turbo_tasks::function]`
`78`	`78`	`fn content(&self) -> Vc<AssetContent> {`
`79`		`- todo!()`
	`79`	`+ panic!("content() should not be called");`
`80`	`80`	`}`
`81`	`81`	`}`
`82`	`82`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ impl Module for ManifestAsyncModule {`
`152`	`152`	`impl Asset for ManifestAsyncModule {`
`153`	`153`	`#[turbo_tasks::function]`
`154`	`154`	`fn content(&self) -> Vc<AssetContent> {`
`155`		`- todo!()`
	`155`	`+ panic!("content() should not be called");`
`156`	`156`	`}`
`157`	`157`	`}`
`158`	`158`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ impl Module for WorkerLoaderModule {`
`62`	`62`	`impl Asset for WorkerLoaderModule {`
`63`	`63`	`#[turbo_tasks::function]`
`64`	`64`	`fn content(&self) -> Vc<AssetContent> {`
`65`		`- todo!()`
	`65`	`+ panic!("content() should not be called");`
`66`	`66`	`}`
`67`	`67`	`}`
`68`	`68`